[libc] Fix memory leak in MPFRWrapper cospif with MPFR pre 4.2. #114415
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lntue
requested review from
SchrodingerZhu,
jhuber6,
michaelrj-google and
nickdesaulniers
lntue
changed the title
Member
|
@llvm/pr-subscribers-libc Author: None (lntue) ChangesFull diff: https://github.com/llvm/llvm-project/pull/114415.diff 1 Files Affected:
diff --git a/libc/utils/MPFRWrapper/MPFRUtils.cpp b/libc/utils/MPFRWrapper/MPFRUtils.cpp
index 60e4abadb5e3c8..4fa6d2f9291993 100644
--- a/libc/utils/MPFRWrapper/MPFRUtils.cpp
+++ b/libc/utils/MPFRWrapper/MPFRUtils.cpp
@@ -262,6 +262,7 @@ class MPFRNumber {
int d = mpz_tstbit(integer, 0);
mpfr_set_si(result.value, d ? -1 : 1, mpfr_rounding);
+ mpz_clear(integer);
return result;
}
@@ -271,7 +272,7 @@ class MPFRNumber {
mpfr_cos(result.value, value_pi.value, mpfr_rounding);
return result;
-#endif
+// #endif
}
MPFRNumber erf() const {
|
nickdesaulniers
approved these changes
Oct 31, 2024
Member
nickdesaulniers
left a comment
nickdesaulniers
left a comment
There was a problem hiding this comment.
If this was fixed in a newer version of MPFR, consider adding a link to the commit in the PR description, and a comment to the sources if this statement should be removed at some point.
Contributor
Author
Unfortunately, this is a bug in our wrapper, not on MPFR side. With newer MPFR, we just call the cospi function directly and there is no bug there. |
smallp-o-p
pushed a commit
to smallp-o-p/llvm-project
that referenced
this pull request
Nov 3, 2024
NoumanAmir657
pushed a commit
to NoumanAmir657/llvm-project
that referenced
this pull request
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.